Skip to content

[fixed] unused variable, standalone running, import doctest module #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 28, 2021
Merged

[fixed] unused variable, standalone running, import doctest module #4673

merged 11 commits into from
Aug 28, 2021

Conversation

slowy07
Copy link
Contributor

@slowy07 slowy07 commented Aug 26, 2021 •
edited
Loading

Describe your change:

fixed unused variable, and using if __name__ == "__main__", and imported doctest module for following style code

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 26, 2021
cclauss
cclauss requested changes Aug 27, 2021
View reviewed changes
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 27, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR labels Aug 27, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 27, 2021
@slowy07 slowy07 requested a review from cclauss August 28, 2021 12:22
cclauss
cclauss requested changes Aug 28, 2021
View reviewed changes
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 28, 2021
@slowy07 @cclauss
Update matrix/spiral_print.py
ef3ea0e 
Co-authored-by: Christian Clauss <[email protected]>
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 28, 2021
@slowy07 @cclauss
Update matrix/spiral_print.py
e6527ab 
Co-authored-by: Christian Clauss <[email protected]>
@ghost ghost added the tests are failing Do not merge until tests pass label Aug 28, 2021
@slowy07 @cclauss
fixing
aa556b8 
Co-authored-by: Christian Clauss <[email protected]>
cclauss
cclauss reviewed Aug 28, 2021
View reviewed changes
@slowy07
[fixed] sprial matrix
8fc1402 
Signed-off-by: slowy07 <[email protected]>
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 28, 2021
@slowy07 slowy07 requested a review from cclauss August 28, 2021 15:23
@ghost ghost added the tests are failing Do not merge until tests pass label Aug 28, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 28, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 28, 2021
@cclauss cclauss merged commit 8e5c353 into TheAlgorithms:master Aug 28, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@slowy07 @cclauss @shermanhui
[fixed] unused variable, standalone running, import doctest module (T…
615cc09 
…heAlgorithms#4673)

* [fixed] unused variable, standalone running, import doctest module

information [standalone running](https://www.geeksforgeeks.org/what-does-the-if-__name__-__main__-do/)

Signed-off-by: slowy07 <[email protected]>

* Update other/fischer_yates_shuffle.py

Co-authored-by: Christian Clauss <[email protected]>

* [fixed] change to tuple and fixing callfunction

Signed-off-by: slowy07 <[email protected]>

* Update matrix/spiral_print.py

Co-authored-by: Christian Clauss <[email protected]>

* Update matrix/spiral_print.py

Co-authored-by: Christian Clauss <[email protected]>

* fixing

Co-authored-by: Christian Clauss <[email protected]>

* [fixed] sprial matrix

Signed-off-by: slowy07 <[email protected]>

* Update spiral_print.py

* Update spiral_print.py

* Update spiral_print.py

* Update spiral_print.py

Co-authored-by: Christian Clauss <[email protected]>
spazm added a commit to spazm/Python that referenced this pull request Oct 29, 2021
@spazm
fischer_yates_shuffle: fixes bug introduced by partial renaming in Th…
2cc5cf4 
…eAlgorithms#4673
@spazm spazm mentioned this pull request Oct 29, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowy07 @cclauss